- Nov 28, 2018
-
-
Guillaume Abrioux authored
change default value of `radosgw_address` to keep consistency with `monitor_address`. Moreover, `ceph-validate` checks if the value is '0.0.0.0' to determine if it has to run `check_eth_rgw.yml`. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1600227 Signed-off-by:
Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit e4869ac8bd574af56952f02b1c8f63ecae0d5d86)
-
- Oct 16, 2018
-
-
Andy McCrae authored
Currently a throw-away container is built to run ceph client commands to setup users, pools & auth keys. This utilises the same base ceph container which has all the ceph services inside it. This PR allows the use of a separate container if the deployer wishes - but defaults to use the same full ceph container. This can be used for different architectures or distributions, which may support the the Ceph client, but not Ceph server, and allows the deployer to build and specify a separate client container if need be. Signed-off-by:
Andy McCrae <andy.mccrae@gmail.com>
-
- Oct 15, 2018
-
-
Nan Li authored
Signed-off-by:
Nan Li <herbert.nan@linaro.org>
-
- Oct 10, 2018
-
-
Noah Watkins authored
Fixes the deprecation warning: [DEPRECATION WARNING]: Using tests as filters is deprecated. Instead of using `result|search` use `result is search`. Signed-off-by:
Noah Watkins <nwatkins@redhat.com>
-
- Sep 27, 2018
-
-
Rishabh Dave authored
Use "import_tasks" or "include_tasks" instead. Signed-off-by:
Rishabh Dave <ridave@redhat.com>
-
- Jun 01, 2018
-
-
Andrew Schoen authored
The first 14.x tag has been cut so this needs to be added so that version detection will still work on the master branch of ceph. Fixes: https://github.com/ceph/ceph-ansible/issues/2671 Signed-off-by:
Andrew Schoen <aschoen@redhat.com>
-
- May 03, 2018
-
-
Andy McCrae authored
The apt-cache update can fail due to transient issues related to the action being a network operation. To reduce the impact of these transient failures this patch adds a retry to the update_cache task. However, the apt_repository tasks which would perform an apt_update won't retry the apt_update on a failure in the same way, as such this PR moves the apt_update into an individual task, once per role. Finally, the apt_repository tasks no longer have a changed_when: false, and the apt_cache update is only performed once per role, if the repositories change. Otherwise the cache is updated on the "apt" install tasks if the cache_timeout has been reached.
-
- Apr 04, 2018
-
-
Guillaume Abrioux authored
This check is alone in `ceph-docker-common` since a previous code refactor. Moving this check in `ceph-defaults` allows us to run `ceph-clients` without having to run `ceph-docker-common` even in non-containerized deployment. Signed-off-by:
Guillaume Abrioux <gabrioux@redhat.com>
-
- Feb 19, 2018
-
-
Paul Bourke authored
This fact is already set in site-docker.yml so there's no need to check it again in ceph-docker-common Signed-off-by:
Paul Bourke <paul.bourke@oracle.com>
-
- Feb 14, 2018
-
-
Sébastien Han authored
We now look for any excisting containers, if any we compare their running image with the latest pulled container image. For OSDs, we iterate over the list of running OSDs, this handles the case where the first OSD of the list has been updated (runs the new image) and not the others. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1526513 Signed-off-by:
Sébastien Han <seb@redhat.com>
-
Sébastien Han authored
This is already defined in ceph-defaults. Signed-off-by:
Sébastien Han <seb@redhat.com>
-
- Jan 31, 2018
-
-
Guillaume Abrioux authored
Use a nicer syntax for `local_action` tasks. We used to have oneliner like this: ``` local_action: wait_for port=22 host={{ hostvars[inventory_hostname]['ansible_default_ipv4']['address'] }} state=started delay=10 timeout=500 }} ``` The usual syntax: ``` local_action: module: wait_for port: 22 host: "{{ hostvars[inventory_hostname]['ansible_default_ipv4']['address'] }}" state: started delay: 10 timeout: 500 ``` is nicer and kind of way to keep consistency regarding the whole playbook. This also fix a potential issue about missing quotation : ``` Traceback (most recent call last): File "/tmp/ansible_wQtWsi/ansible_module_command.py", line 213, in <module> main() File "/tmp/ansible_wQtWsi/ansible_module_command.py", line 185, in main rc, out, err = module.run_command(args, executable=executable, use_unsafe_shell=shell, encoding=None, data=stdin) File "/tmp/ansible_wQtWsi/ansible_modlib.zip/ansible/module_utils/basic.py", line 2710, in run_command File "/usr/lib64/python2.7/shlex.py", line 279, in split return list(lex) File "/usr/lib64/python2.7/shlex.py", line 269, in next token = self.get_token() File "/usr/lib64/python2.7/shlex.py", line 96, in get_token raw = self.read_token() File "/usr/lib64/python2.7/shlex.py", line 172, in read_token raise ValueError, "No closing quotation" ValueError: No closing quotation ``` writing `local_action: shell echo {{ fsid }} | tee {{ fetch_directory }}/ceph_cluster_uuid.conf` can cause trouble because it's complaining with missing quotes, this fix solves this issue. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1510555 Signed-off-by:
Guillaume Abrioux <gabrioux@redhat.com>
-
- Jan 10, 2018
-
-
Guillaume Abrioux authored
Having handlers in both ceph-defaults and ceph-docker-common roles can make the playbook restarting two times services. Handlers can be triggered first time because of a change in ceph.conf and a second time because a new image has been pulled. Signed-off-by:
Guillaume Abrioux <gabrioux@redhat.com>
-
Sébastien Han authored
This wasn't any good choice to implement this. We had several options and none of them were ideal since handlers can not be triggered cross-roles. We could have achieved that by doing: * option 1 was to add a dependancy in the meta of the ceph-docker-common role. We had that long ago and we decided to stop so everything is managed via site.yml * option 2 was to import files from another role. This is messy and we don't that anywhere in the current code base. We will continue to do so. There is option 3 where we pull the image from the ceph-config role. This is not suitable as well since the docker command won't be available unless you run Atomic distro. This would also mean that you're trying to pull twice. First time in ceph-config, second time in ceph-docker-common The only option I came up with was to duplicate a bit of the ceph-config handlers code. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1526513 Signed-off-by:
Sébastien Han <seb@redhat.com>
-
Sébastien Han authored
Previously we were using ceph_conf_overrides however this doesn't play nice for softwares like TripleO that uses ceph_conf_overrides inside its own code. For now, and since this is the only occurence of this, we can ensure no logs through the ceph conf template. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1532619 Signed-off-by:
Sébastien Han <seb@redhat.com>
-
- Dec 15, 2017
-
-
Christian Berendt authored
The name docker_version is very generic and is also used by other roles. As a result, there may be name conflicts. To avoid this a ceph_ prefix should be used for this fact. Since it is an internal fact renaming is not a problem.
-
- Nov 14, 2017
-
-
Markos Chandras authored
Add support for the openSUSE Leap distributions. Signed-off-by:
Markos Chandras <mchandras@suse.de>
-
- Nov 03, 2017
-
-
Sébastien Han authored
During the initial implementation of this 'old' thing we were falling into this issue without noticing https://github.com/moby/moby/issues/30341 and where blindly using --rm, now this is fixed the prepare container disappears and thus activation fail. I'm fixing this for old jewel images. Also this fixes the machine reboot case where the docker logs are purgend. In the old scenario, we now store the log locally in the same directory as the ceph-osd-run.sh script. Signed-off-by:
Sébastien Han <seb@redhat.com>
-
- Oct 27, 2017
-
-
Sébastien Han authored
Docker image pull retry
-
- Oct 25, 2017
-
-
Joe Talerico authored
This change sets a default timeout of 300s for the image pull. If the image pull times out (300s), we will retry 3 times by default. fixes 1954
-
Major Hayden authored
This patch changes the `always_run: yes` task option to `check_mode: no` to avoid Ansible warnings.
-
Major Hayden authored
This reverts commit 620fb37d.
-
- Oct 20, 2017
-
-
Sébastien Han authored
stable-3.0 brought numerous changes in ceph-ansible variables, this PR aims to maintain backward compatibility for someone running stable-2.2 upgrading to stable-3.0 but keeps its groups_vars untouched. We will then determine the right options to make sure the upgrade works but we are expecting that new variables should be used. We will drop this in a near future, maybe 3.1 or 3.2. Signed-off-by:
Sébastien Han <seb@redhat.com>
-
- Oct 17, 2017
-
-
Christian Berendt authored
The contents of the README files are no longer up to date. Documentation for all roles is located below the docs directory.
-
- Oct 13, 2017
-
-
Sébastien Han authored
The container deployment is serialized, adding this task as a best effort. If docker is already present we pull the image otherwise we wait for the role to play. Signed-off-by:
Sébastien Han <seb@redhat.com>
-
- Oct 12, 2017
-
-
Sébastien Han authored
Suppress yum/dnf/rpm command warnings
-
Major Hayden authored
Ansible throws warnings when using yum/dnf/rpm with the command module: [WARNING]: Consider using yum module rather than running yum This patch adds the `warn: no` argument to suppress the warnings in the Ansible output.
-
Major Hayden authored
The `always_run` key is deprecated and being removed in Ansible 2.4. Using it causes a warning to be displayed: [DEPRECATION WARNING]: always_run is deprecated. This patch changes all instances of `always_run` to use the `always` tag, which causes the task to run each time the playbook runs.
-
- Oct 05, 2017
-
-
Guillaume Abrioux authored
All keyring are getting copied to all nodes. This commit fixes a leftover from a previous code refactor. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1498583 Signed-off-by:
Guillaume Abrioux <gabrioux@redhat.com>
-
- Sep 27, 2017
-
-
Guillaume Abrioux authored
there is no need to backslash the quotes here. Signed-off-by:
Guillaume Abrioux <gabrioux@redhat.com>
-
- Sep 21, 2017
-
-
Guillaume Abrioux authored
there is no need to build the `ceph_config_keys` fact in several steps for rbd-mirror keyring. Signed-off-by:
Guillaume Abrioux <gabrioux@redhat.com>
-
Guillaume Abrioux authored
`docker ps` will always return `0` (see: https://github.com/docker/cli/issues/538 ). Signed-off-by:
Guillaume Abrioux <gabrioux@redhat.com>
-
- Sep 18, 2017
-
-
Sébastien Han authored
When Ansible is not run with verbose options it's difficult to see which include and/or set_fact does what. So adding a name for each clarifies. Signed-off-by:
Sébastien Han <seb@redhat.com>
-
Sébastien Han authored
The variable "statleftover" was removed by commit a60c74f6 and never added back to the new playbook, yet it is still being referenced. Adding it back Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1492224 Signed-off-by:
Sébastien Han <seb@redhat.com>
-
- Sep 11, 2017
-
-
Guillaume Abrioux authored
All keys are copied to all nodes. This commit split that task in each roles so keys are copied to their respective nodes. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1488999 Signed-off-by:
Guillaume Abrioux <gabrioux@redhat.com>
-
- Sep 07, 2017
-
-
Sébastien Han authored
container: introduce resource limitation for containers
-
- Sep 06, 2017
-
-
Sébastien Han authored
This can be controlled via 2 options: * ceph_$DAEMON_docker_memory_limit * ceph_$DAEMON_docker_cpu_limit All daemons default to 1GB for memory and 1 CPU by default. Recommendations from: https://access.redhat.com/documentation/en-us/red_hat_ceph_storage/2/html/red_hat_ceph_storage_hardware_guide/minimum_recommendations Signed-off-by:
Sébastien Han <seb@redhat.com>
-
- Sep 05, 2017
-
-
Sébastien Han authored
We must mask the image so we are sure that even if the system reboots then the OSDs won't start. Also remove Ceph udev rules if found on the system prior to deploy containers. If we don't do this we are exposed to conflicts between udev rules and sytemd unit files. Also add the CI will now test the migration from a non-containerized cluster to a containerized cluster. Signed-off-by:
Sébastien Han <seb@redhat.com>
-
Sébastien Han authored
ceph-docker-common: do not log inside the container
-
- Aug 30, 2017
-
-
Sébastien Han authored
osd: allow multi dedicated journals for containers
-