Skip to content
Snippets Groups Projects
  1. Nov 28, 2018
  2. Oct 16, 2018
    • Andy McCrae's avatar
      Add ability to use a different client container · 66e9e540
      Andy McCrae authored
      
      Currently a throw-away container is built to run ceph client
      commands to setup users, pools & auth keys. This utilises
      the same base ceph container which has all the ceph services
      inside it.
      
      This PR allows the use of a separate container if the deployer
      wishes - but defaults to use the same full ceph container.
      
      This can be used for different architectures or distributions,
      which may support the the Ceph client, but not Ceph server,
      and allows the deployer to build and specify a separate client
      container if need be.
      
      Signed-off-by: default avatarAndy McCrae <andy.mccrae@gmail.com>
      8 tags
      66e9e540
  3. Oct 15, 2018
  4. Oct 10, 2018
  5. Sep 27, 2018
  6. Jun 01, 2018
  7. May 03, 2018
    • Andy McCrae's avatar
      Move apt cache update to individual task per role · 7e7aac78
      Andy McCrae authored
      The apt-cache update can fail due to transient issues related to the
      action being a network operation. To reduce the impact of these
      transient failures this patch adds a retry to the update_cache task.
      
      However, the apt_repository tasks which would perform an apt_update
      won't retry the apt_update on a failure in the same way, as such this PR
      moves the apt_update into an individual task, once per role.
      
      Finally, the apt_repository tasks no longer have a changed_when: false,
      and the apt_cache update is only performed once per role, if the
      repositories change. Otherwise the cache is updated on the "apt" install
      tasks if the cache_timeout has been reached.
      6 tags
      7e7aac78
  8. Apr 04, 2018
  9. Feb 19, 2018
  10. Feb 14, 2018
  11. Jan 31, 2018
    • Guillaume Abrioux's avatar
      syntax: change local_action syntax · 1330c5da
      Guillaume Abrioux authored
      Use a nicer syntax for `local_action` tasks.
      We used to have oneliner like this:
      ```
      local_action: wait_for port=22 host={{ hostvars[inventory_hostname]['ansible_default_ipv4']['address'] }} state=started delay=10 timeout=500 }}
      ```
      
      The usual syntax:
      ```
          local_action:
            module: wait_for
            port: 22
            host: "{{ hostvars[inventory_hostname]['ansible_default_ipv4']['address'] }}"
            state: started
            delay: 10
            timeout: 500
      ```
      is nicer and kind of way to keep consistency regarding the whole
      playbook.
      
      This also fix a potential issue about missing quotation :
      
      ```
      Traceback (most recent call last):
        File "/tmp/ansible_wQtWsi/ansible_module_command.py", line 213, in <module>
          main()
        File "/tmp/ansible_wQtWsi/ansible_module_command.py", line 185, in main
          rc, out, err = module.run_command(args, executable=executable, use_unsafe_shell=shell, encoding=None, data=stdin)
        File "/tmp/ansible_wQtWsi/ansible_modlib.zip/ansible/module_utils/basic.py", line 2710, in run_command
        File "/usr/lib64/python2.7/shlex.py", line 279, in split
          return list(lex)                                                                                                                                                                                                                                                                                                            File "/usr/lib64/python2.7/shlex.py", line 269, in next
          token = self.get_token()
        File "/usr/lib64/python2.7/shlex.py", line 96, in get_token
          raw = self.read_token()
        File "/usr/lib64/python2.7/shlex.py", line 172, in read_token
          raise ValueError, "No closing quotation"
      ValueError: No closing quotation
      ```
      
      writing `local_action: shell echo {{ fsid }} | tee {{ fetch_directory }}/ceph_cluster_uuid.conf`
      can cause trouble because it's complaining with missing quotes, this fix solves this issue.
      
      Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1510555
      
      
      
      Signed-off-by: default avatarGuillaume Abrioux <gabrioux@redhat.com>
      1330c5da
  12. Jan 10, 2018
    • Guillaume Abrioux's avatar
      handlers: avoid duplicate handler · 3b9893f4
      Guillaume Abrioux authored
      
      Having handlers in both ceph-defaults and ceph-docker-common roles can make the
      playbook restarting two times services. Handlers can be triggered first
      time because of a change in ceph.conf and a second time because a new
      image has been pulled.
      
      Signed-off-by: default avatarGuillaume Abrioux <gabrioux@redhat.com>
      3b9893f4
    • Sébastien Han's avatar
      container: restart container when there is a new image · 8a2c000b
      Sébastien Han authored
      This wasn't any good choice to implement this.
      We had several options and none of them were ideal since handlers can
      not be triggered cross-roles.
      We could have achieved that by doing:
      
      * option 1 was to add a dependancy in the meta of the ceph-docker-common
      role. We had that long ago and we decided to stop so everything is
      managed via site.yml
      
      * option 2 was to import files from another role. This is messy and we
      don't that anywhere in the current code base. We will continue to do so.
      
      There is option 3 where we pull the image from the ceph-config role.
      This is not suitable as well since the docker command won't be available
      unless you run Atomic distro. This would also mean that you're trying to
      pull twice. First time in ceph-config, second time in ceph-docker-common
      
      The only option I came up with was to duplicate a bit of the ceph-config
      handlers code.
      
      Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1526513
      
      
      Signed-off-by: default avatarSébastien Han <seb@redhat.com>
      8a2c000b
    • Sébastien Han's avatar
      container: change the way we force no logs inside the container · 88227872
      Sébastien Han authored
      Previously we were using ceph_conf_overrides however this doesn't play
      nice for softwares like TripleO that uses ceph_conf_overrides inside its
      own code. For now, and since this is the only occurence of this, we can
      ensure no logs through the ceph conf template.
      
      Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1532619
      
      
      Signed-off-by: default avatarSébastien Han <seb@redhat.com>
      88227872
  13. Dec 15, 2017
  14. Nov 14, 2017
  15. Nov 03, 2017
    • Sébastien Han's avatar
      osd: enhance backward compatibility · 35953fd7
      Sébastien Han authored
      During the initial implementation of this 'old' thing we were falling
      into this issue without noticing
      https://github.com/moby/moby/issues/30341
      
       and where blindly using --rm,
      now this is fixed the prepare container disappears and thus activation
      fail.
      I'm fixing this for old jewel images.
      
      Also this fixes the machine reboot case where the docker logs are
      purgend. In the old scenario, we now store the log locally in the same
      directory as the ceph-osd-run.sh script.
      
      Signed-off-by: default avatarSébastien Han <seb@redhat.com>
      35953fd7
  16. Oct 27, 2017
  17. Oct 25, 2017
  18. Oct 20, 2017
    • Sébastien Han's avatar
      all: backward compatibility between stable-2.2 and 3.0 · 6d097855
      Sébastien Han authored
      
      stable-3.0 brought numerous changes in ceph-ansible variables, this PR
      aims to maintain backward compatibility for someone running stable-2.2
      upgrading to stable-3.0 but keeps its groups_vars untouched.
      We will then determine the right options to make sure the upgrade works
      but we are expecting that new variables should be used.
      
      We will drop this in a near future, maybe 3.1 or 3.2.
      
      Signed-off-by: default avatarSébastien Han <seb@redhat.com>
      6d097855
  19. Oct 17, 2017
  20. Oct 13, 2017
  21. Oct 12, 2017
    • Sébastien Han's avatar
      Merge pull request #2038 from major/fix-cmd-warning · a2c43314
      Sébastien Han authored
      Suppress yum/dnf/rpm command warnings
      a2c43314
    • Major Hayden's avatar
      Suppress yum/dnf/rpm command warnings · 945c3756
      Major Hayden authored
      Ansible throws warnings when using yum/dnf/rpm with the command
      module:
      
          [WARNING]: Consider using yum module rather than running yum
      
      This patch adds the `warn: no` argument to suppress the warnings
      in the Ansible output.
      945c3756
    • Major Hayden's avatar
      Avoid deprecated always_run · 46c7d230
      Major Hayden authored
      The `always_run` key is deprecated and being removed in Ansible 2.4.
      Using it causes a warning to be displayed:
      
          [DEPRECATION WARNING]: always_run is deprecated.
      
      This patch changes all instances of `always_run` to use the `always`
      tag, which causes the task to run each time the playbook runs.
      46c7d230
  22. Oct 05, 2017
  23. Sep 27, 2017
  24. Sep 21, 2017
  25. Sep 18, 2017
  26. Sep 11, 2017
  27. Sep 07, 2017
  28. Sep 06, 2017
  29. Sep 05, 2017
  30. Aug 30, 2017
Loading